Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minimal diff to be able to return the task response bytes instead of just the task response digest #252

Merged
merged 8 commits into from
May 29, 2024
Merged

minimal diff to be able to return the task response bytes instead of just the task response digest #252

merged 8 commits into from
May 29, 2024

Conversation

afkbyte
Copy link
Contributor

@afkbyte afkbyte commented May 25, 2024 •
edited
Loading

Fixes AVS-218

Update bls_aggregation service to return the Task Response bytes

What Changed?

  • Added the type TaskResponse to the avs types and include it in the BlsAggregationServiceResponse
  • Update ProcessNewSignature to take in the TaskResponse as a parameter instead of the TaskReponseDigest
  • Update SignedTaskResponseDigest to return the TaskResponse rather than the TaskResponseDigest
    • Compute the TaskResponseDigest to be signed in the function as the hashFunction of the TaskResponse bytes

TODO: update comments

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@afkbyte afkbyte requested a review from samlaf May 25, 2024 03:58
@afkbyte afkbyte changed the title minimal diff to be able to return the task response bytes minimal diff to be able to return the task response bytes instead of just the task response digest May 25, 2024
@afkbyte afkbyte requested a review from shrimalmadhur May 25, 2024 04:16
samlaf
samlaf reviewed May 26, 2024
View reviewed changes
Copy link
Collaborator

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome this looks exactly like what I had in mind.
Left 2 comments based on style, we can discuss.

services/bls_aggregation/blsagg.go Outdated Show resolved Hide resolved
types/avs.go Show resolved Hide resolved
@afkbyte afkbyte marked this pull request as ready for review May 29, 2024 04:24
@afkbyte afkbyte requested a review from samlaf May 29, 2024 04:48
@samlaf samlaf merged commit aebab47 into master May 29, 2024
3 checks passed
@samlaf samlaf deleted the afkbyte-avs-218-fix-blsagg-service-to-store-and-return-msgs-not-their-hash branch May 29, 2024 04:58
@TomasArrachea TomasArrachea mentioned this pull request Nov 15, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlaf samlaf samlaf approved these changes

@shrimalmadhur shrimalmadhur Awaiting requested review from shrimalmadhur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afkbyte @samlaf